invalidate stage builds only by the files they use #115
Labels
Comments
turadg
changed the title
This was referenced Jan 14, 2025
mergify bot
added a commit
to Agoric/agoric-sdk
that referenced
this issue
Jan 23, 2025
refs: Agoric/agoric-3-proposals#115 ## Description A3P is getting this feature, - Agoric/agoric-3-proposals#213 This PR takes advantage of it for a3p-integration tests. ### Security Considerations none, just test ### Scaling Considerations none, just test ### Documentation Considerations none ### Testing Considerations per se ### Upgrade Considerations none, just test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
It's convenient to have all the files for the proposal at its top level, but because the Docker build doesn't know which will be needed for any stage, it has to copy them all. That entails invalidating the non-test stages when tests update.
Design
Files used only in testing shouldn't be copied before the test stage.
Use the new COPY --exclude to exclude
*test*files before the test stage.Consider doing the same for "use" stage with, perhaps, a
*use*pattern.Acceptance criteria
Modifying "test" files only invalidates the test image, not the prepare, exec, use, etc
Bonus: modifying "use" files only invalidates the use stage of the use image, not the prepare, exec, etc
The text was updated successfully, but these errors were encountered: