Skip to content

Commit 6a8c285

Browse files
add php7.2 + php7.3 travis builds (#59)
* add php7.2 + php7.3 travis builds * INTL_IDNA_VARIANT_2003 vs INTL_IDNA_VARIANT_UTS46 thx @krtcom * remove deprected phpunit config
1 parent 12529e4 commit 6a8c285

File tree

4 files changed

+5
-4
lines changed

4 files changed

+5
-4
lines changed

.travis.yml

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,8 +2,10 @@ language: php
22

33
matrix:
44
include:
5-
- php: 7.1
5+
- php: 7.3
6+
- php: 7.2
67
env: RUN_COVERAGE=1
8+
- php: 7.1
79
- php: 7.0
810
- php: 5.6
911
- php: 5.5

phpunit.xml.dist

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,6 @@
77
processIsolation="false"
88
stopOnError="false"
99
stopOnFailure="false"
10-
syntaxCheck="true"
1110
verbose="true"
1211
>
1312
<testsuites>

src/AfriCC/EPP/Validator.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -328,7 +328,7 @@ public static function isEmail($email)
328328
return false;
329329
}
330330

331-
$ascii_email = substr($email, 0, $pos) . '@' . idn_to_ascii(substr($email, $pos + 1), 0, INTL_IDNA_VARIANT_2003);
331+
$ascii_email = substr($email, 0, $pos) . '@' . idn_to_ascii(substr($email, $pos + 1), IDNA_DEFAULT, INTL_IDNA_VARIANT_UTS46);
332332

333333
return (bool) filter_var($ascii_email, FILTER_VALIDATE_EMAIL);
334334
}

tests/EPP/Extension/NICMX/Restore/DomainTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@
55
use AfriCC\EPP\Extension\NICMX\Restore\Domain;
66
use PHPUnit\Framework\TestCase;
77

8-
class DomainRestoreTest extends TestCase
8+
class DomainTest extends TestCase
99
{
1010
public function testNicMxRestoreDomainFrame()
1111
{

0 commit comments

Comments
 (0)