Merge pull request #42 from AfriCC/analysis-8m935Y

Apply fixes from StyleCI

Author: lifeofguenter

examples/check_contact.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Check\Contact as CheckContact;
 
-$frame = new CheckContact;
+$frame = new CheckContact();
 $frame->addId('sh8013');
 $frame->addId('sah8013');
 $frame->addId('8013sah');

examples/check_domain.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Check\Domain as CheckDomain;
 
-$frame = new CheckDomain;
+$frame = new CheckDomain();
 $frame->addDomain('example.com');
 $frame->addDomain('example.org');
 $frame->addDomain('example.net');

examples/check_host.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Check\Host as CheckHost;
 
-$frame = new CheckHost;
+$frame = new CheckHost();
 $frame->addHost('ns1.example.com');
 $frame->addHost('ns2.example.com');
 $frame->addHost('ns3.example.com');

examples/connect.php

@@ -16,17 +16,17 @@
     'password' => 'grodotzki',
     'services' => [
         'urn:ietf:params:xml:ns:domain-1.0',
-        'urn:ietf:params:xml:ns:contact-1.0'
+        'urn:ietf:params:xml:ns:contact-1.0',
     ],
     'debug' => true,
 ]);
 
 try {
     $greeting = $epp_client->connect();
-} catch(Exception $e) {
+} catch (Exception $e) {
     echo $e->getMessage() . PHP_EOL;
     unset($epp_client);
     exit(1);
 }
 
-$epp_client->close();
+$epp_client->close();

examples/create_contact.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Create\Contact as CreateContact;
 
-$frame = new CreateContact;
+$frame = new CreateContact();
 $frame->setId('CONTACT1');
 $frame->setName('Günter Grodotzki');
 $frame->setName('Jun Grodotzki');

examples/create_contact_disclose.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Create\Contact as CreateContact;
 
-$frame = new CreateContact;
+$frame = new CreateContact();
 $frame->skipInt();
 $frame->setId('CONTACT1');
 $frame->setName('Günter Grodotzki');

examples/create_contact_skipint.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Create\Contact as CreateContact;
 
-$frame = new CreateContact;
+$frame = new CreateContact();
 $frame->skipInt();
 $frame->setId('CONTACT1');
 $frame->setName('Günter Grodotzki');

examples/create_domain.php

@@ -10,13 +10,13 @@
 
 use AfriCC\EPP\Frame\Command\Create\Domain as CreateDomain;
 
-$frame = new CreateDomain;
+$frame = new CreateDomain();
 $frame->setDomain('google.co.uk');
 $frame->setPeriod('1y');
 //$frame->addHostObj('ns1.googledns.com');
 //$frame->addHostObj('ns2.googledns.com');
 $frame->addHostAttr('ns1.google.co.uk', [
-	'8.8.8.8',
+    '8.8.8.8',
     '2a00:1450:4009:809::100e',
 ]);
 $frame->addHostAttr('ns2.google.com');

examples/create_host.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Create\Host as CreateHost;
 
-$frame = new CreateHost;
+$frame = new CreateHost();
 $frame->setHost('ns1.example.com');
 $frame->setHost('ns2.example.com');
 $frame->addAddr('8.8.8.8');

examples/delete_contact.php

@@ -10,6 +10,6 @@
 
 use AfriCC\EPP\Frame\Command\Delete\Contact as DeleteContact;
 
-$frame = new DeleteContact;
+$frame = new DeleteContact();
 $frame->setId('C001');
 echo $frame;

examples/delete_domain.php

@@ -10,6 +10,6 @@
 
 use AfriCC\EPP\Frame\Command\Delete\Domain as DeleteDomain;
 
-$frame = new DeleteDomain;
+$frame = new DeleteDomain();
 $frame->setDomain('google.com');
 echo $frame;

examples/delete_host.php

@@ -10,6 +10,6 @@
 
 use AfriCC\EPP\Frame\Command\Delete\Host as DeleteHost;
 
-$frame = new DeleteHost;
+$frame = new DeleteHost();
 $frame->setHost('ns1.google.com');
 echo $frame;

examples/extension.php

@@ -11,23 +11,23 @@
 use AfriCC\EPP\Extension\COZA\Info\CozaContact as CozaContactInfoExtension;
 use AfriCC\EPP\Extension\COZA\Update\CozaContact as CozaContactUpdateExtension;
 
-$frame = new CozaContactInfoExtension;
+$frame = new CozaContactInfoExtension();
 $frame->setId('MyContact');
 $frame->setAuthInfo('password');
 $frame->requestBalance();
 echo $frame;
 
 echo PHP_EOL;
 
-$frame = new CozaContactInfoExtension;
+$frame = new CozaContactInfoExtension();
 $frame->setId('MyContact');
 $frame->setAuthInfo('password');
 $frame->requestDomainListing();
 echo $frame;
 
 echo PHP_EOL;
 
-$frame = new CozaContactUpdateExtension;
+$frame = new CozaContactUpdateExtension();
 $frame->setId('MyContact');
 $frame->cancelPendingAction();
 echo $frame;

examples/info_contact.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Info\Contact as InfoContact;
 
-$frame = new InfoContact;
+$frame = new InfoContact();
 $frame->setId('C001');
 $frame->setAuthInfo('password');
 echo $frame;

examples/info_domain.php

@@ -10,6 +10,6 @@
 
 use AfriCC\EPP\Frame\Command\Info\Domain as InfoDomain;
 
-$frame = new InfoDomain;
+$frame = new InfoDomain();
 $frame->setDomain('example.com', 'all');
 echo $frame;

examples/info_host.php

@@ -10,6 +10,6 @@
 
 use AfriCC\EPP\Frame\Command\Info\Host as InfoHost;
 
-$frame = new InfoHost;
+$frame = new InfoHost();
 $frame->setHost('ns1.google.com');
 echo $frame;

examples/login.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Login;
 
-$frame = new Login;
+$frame = new Login();
 $frame->setClientId('gunter');
 $frame->setPassword('grodotzki');
 $frame->setNewPassword('grodotzki2');

examples/login_extensions.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Login;
 
-$frame = new Login;
+$frame = new Login();
 $frame->setClientId('gunter');
 $frame->setPassword('grodotzki');
 $frame->setNewPassword('grodotzki2');

examples/logout.php

@@ -10,5 +10,5 @@
 
 use AfriCC\EPP\Frame\Command\Logout;
 
-$frame = new Logout;
+$frame = new Logout();
 echo $frame;

examples/poll.php

@@ -10,12 +10,12 @@
 
 use AfriCC\EPP\Frame\Command\Poll;
 
-$frame = new Poll;
+$frame = new Poll();
 $frame->request();
 echo $frame;
 
 echo PHP_EOL;
 
-$frame = new Poll;
+$frame = new Poll();
 $frame->ack('FMS-EPP-12A18BE965E-6D25E');
 echo $frame;

examples/renew_domain.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Renew\Domain as RenewDomain;
 
-$frame = new RenewDomain;
+$frame = new RenewDomain();
 $frame->setDomain('google.com');
 $frame->setCurrentExpirationDate(date('Y-m-d'));
 $frame->setPeriod('6m');

examples/transfer_contact.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Transfer\Contact as TransferContact;
 
-$frame = new TransferContact;
+$frame = new TransferContact();
 $frame->setOperation('request');
 $frame->setId('C001');
 $frame->setAuthInfo('password');

examples/transfer_domain.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Transfer\Domain as TransferDomain;
 
-$frame = new TransferDomain;
+$frame = new TransferDomain();
 $frame->setOperation('cancel');
 $frame->setDomain('google.com');
 $frame->setPeriod('6y');

examples/transfer_query.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Transfer\Domain as TransferDomain;
 
-$frame = new TransferDomain;
+$frame = new TransferDomain();
 $frame->setOperation('query');
 $frame->setDomain('google.com');
 $frame->setAuthInfo('password');

examples/update_contact.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Update\Contact as UpdateContact;
 
-$frame = new UpdateContact;
+$frame = new UpdateContact();
 $frame->setId('C0054');
 $frame->addCity('Voerde');
 $frame->addAddStreet('Long St. 14');

examples/update_contact_disclose.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Update\Contact as UpdateContact;
 
-$frame = new UpdateContact;
+$frame = new UpdateContact();
 $frame->setId('C0054');
 $frame->addCity('Voerde');
 $frame->addAddStreet('Long St. 14');

examples/update_domain.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Update\Domain as UpdateDomain;
 
-$frame = new UpdateDomain;
+$frame = new UpdateDomain();
 $frame->setDomain('google.com');
 $frame->addAdminContact('ADMIN-1');
 $frame->addTechContact('TECH-2');

examples/update_host.php

@@ -10,7 +10,7 @@
 
 use AfriCC\EPP\Frame\Command\Update\Host as UpdateHost;
 
-$frame = new UpdateHost;
+$frame = new UpdateHost();
 $frame->setHost('ns1.google.com');
 $frame->addAddr('8.8.8.8');
 $frame->addAddr('2a00:1450:4009:803::1009');

src/AfriCC/EPP/AbstractFrame.php

@@ -77,7 +77,7 @@ public function get($query)
 
         // @see http://stackoverflow.com/a/24730245/567193
         if ($nodes->length === 1 && (
-                ($last_bit{0} === '@' && $nodes->item(0)->nodeType === XML_ATTRIBUTE_NODE) ||
+                ($last_bit[0] === '@' && $nodes->item(0)->nodeType === XML_ATTRIBUTE_NODE) ||
                 (stripos($last_bit, 'text()') === 0 && $nodes->item(0)->nodeType === XML_TEXT_NODE)
             )) {
             return $nodes->item(0)->nodeValue;
@@ -94,10 +94,9 @@ public function __toString()
     protected function createNodes($path)
     {
         $path_parts = explode('/', $path);
-        $node_path  = null;
+        $node_path = null;
 
         for ($i = 0, $limit = count($path_parts); $i < $limit; ++$i) {
-
             $attr_name = $attr_value = null;
 
             // if no namespace given, use root-namespace
@@ -130,8 +129,8 @@ protected function createNodes($path)
             }
             // check if attribute needs to be set
             elseif (preg_match('/^(.*)\[@([a-z0-9]+)=\'([a-z0-9]+)\'\]$/i', $node_name, $matches)) {
-                $node_name  = $matches[1];
-                $attr_name  = $matches[2];
+                $node_name = $matches[1];
+                $attr_name = $matches[2];
                 $attr_value = $matches[3];
             }
 
@@ -177,7 +176,7 @@ protected function realxpath($path)
             $path_parts = [];
         }
         // absolute path
-        elseif (isset($path{1}) && $path{0} === '/' && $path{1} === '/') {
+        elseif (isset($path[1]) && $path[0] === '/' && $path[1] === '/') {
             return substr($path, 2);
         } else {
             $path_parts = explode('/', $path);
@@ -196,6 +195,7 @@ protected function realxpath($path)
         }
 
         array_unshift($path_parts, 'epp:epp');
+
         return implode('/', $path_parts);
     }
 
@@ -222,7 +222,7 @@ private function getStructure()
             } elseif (empty($this->command) && $parent_class === 'Command') {
                 $this->command = strtolower($bare_class);
             } elseif ($parent_class === 'AbstractFrame') {
-                $this->format  = strtolower($bare_class);
+                $this->format = strtolower($bare_class);
             }
         }
 
@@ -245,6 +245,7 @@ private function className($class)
         if (($pos = strrpos($class, '\\')) === false) {
             return $class;
         }
+
         return substr($class, $pos + 1);
     }
 }