bug: budget step validation doesn't catch NaN, letting "NaN" reach the escrow review total

[JamesVictor-O]

Problem

The campaign budget step's validation doesn't catch NaN, letting a broken budget value silently reach the final review screen.

components/campaigns/new/steps/step-budget.tsx:

<input type="number" min={0} value={data.totalBudget || ""}
  onChange={(e) => update({ totalBudget: Number(e.target.value) })} .../>

components/dashboard/business/campaign-wizard-modal.tsx:

if (state.budget.totalBudget <= 0) errors.totalBudget = "Budget must be greater than 0.";

Typing a lone - (or any non-numeric string) into the budget field yields Number("-") === NaN. Since NaN <= 0 evaluates to false in JavaScript, this validation is silently bypassed. The input visually clears (NaN || "" renders empty), so it looks like nothing happened — but state.budget.totalBudget is now NaN, and clicking "Next Step" proceeds past step 3 with no error shown.

Concrete failure scenario

1. User types - into "Total Campaign Budget." The field looks empty.
2. Validation passes (NaN <= 0 is false), so "Next Step" advances normally.
3. The Review step (step-review-fund.tsx) renders total.toLocaleString() — showing "NaN" / "≈ $NaN USD" as the amount to lock in escrow, an unmistakably broken value on the last screen before a funding action.

Expected behaviour

Validate with Number.isFinite(state.budget.totalBudget) && state.budget.totalBudget > 0 instead of a bare <= 0 comparison, so non-numeric input is caught with a clear inline error instead of silently passing through as NaN.

Files

• components/dashboard/business/campaign-wizard-modal.tsx — validateStep
• components/campaigns/new/steps/step-budget.tsx — input handling

Acceptance criteria

• Typing non-numeric input (e.g. a lone -) into the budget field produces a visible validation error, not a silent pass-through
• The wizard cannot advance past the budget step with a NaN totalBudget
• The Review step never renders "NaN" for the budget total

[Unclebaffa]

Hi team,

I would love to pick up this validation bug. As a web developer actively contributing to the GrantFox repository, I can quickly fix this JavaScript NaN quirk to ensure the campaign wizard properly blocks invalid inputs and keeps the escrow review screen clean.

Here is my straightforward implementation plan:

1. Fix Validation Logic

• Update validateStep within components/dashboard/business/campaign-wizard-modal.tsx.
• Replace the bare <= 0 comparison with a strict numeric check: if (!Number.isFinite(state.budget.totalBudget) || state.budget.totalBudget <= 0). This guarantees that NaN triggers the appropriate inline error instead of silently bypassing the guard.

2. State Handling & UI Feedback

• Review the onChange event in components/campaigns/new/steps/step-budget.tsx to ensure that when NaN is caught, the validation error correctly surfaces in the UI, blocking the user from proceeding to the next step.

3. Verification

• Manually test the form by inputting edge cases like a lone - or non-numeric strings to guarantee the wizard cannot advance to the final review screen with broken data.

[annieolivia61-ux]

I will love to fix this new issue

[grantfox-oss]

🦊 GrantFox — @Unclebaffa has been assigned to this issue as part of the Third Campaign campaign!

Next steps:

1. Open a Pull Request referencing this issue (e.g., Closes #144)
2. Your PR will be reviewed by the Ads-Bazaar maintainers

Good luck! Track your progress on GrantFox.