Scissors - Araceli #41
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Jan 25, 2022
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Nice work Araceli, you hit the learning goals here. Really nice work with the in-place solution to HeapSort.
I left a few notes on time/space complexity.
Comment on lines
+3
to
7
| def heap_sort(arr): | ||
| """ This method uses a heap to sort an array. | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O (log n) | ||
| Space Complexity: O(1) | ||
| """ |
There was a problem hiding this comment.
👍 Awesome work an O(1) heapsort solution. Nice work.
Comment on lines
19
to
24
| def add(self, key, value = None): | ||
| """ This method adds a HeapNode instance to the heap | ||
| If value == None the new node's value should be set to key | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(log n) | ||
| Space Complexity: O(1) | ||
| """ |
There was a problem hiding this comment.
👍 However this is O(log n) for space complexity because heap_up is recursive and you have the call stack.
Comment on lines
35
to
+39
| def remove(self): | ||
| """ This method removes and returns an element from the heap | ||
| maintaining the heap structure | ||
| Time Complexity: ? | ||
| Space Complexity: ? | ||
| Time Complexity: O(log n) | ||
| Space Complexity: O(1) |
There was a problem hiding this comment.
👍 However space complexity is O(log n) due to the recursive call stack.
| return f"[{', '.join([str(element) for element in self.store])}]" | ||
|
|
||
|
|
||
| def empty(self): |
|
|
||
| return self.store | ||
|
|
||
| def heap_up(self, index): |
There was a problem hiding this comment.
👍 However time/space complexity are both O(log n) due to recursion.
Comment on lines
88
to
93
| def heap_down(self, index): | ||
| """ This helper method takes an index and | ||
| moves the corresponding element down the heap if it's | ||
| larger than either of its children and continues until | ||
| the heap property is reestablished. | ||
| """ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Heaps Practice
Congratulations! You're submitting your assignment!
Comprehension Questions
heap_up&heap_downmethods useful? Why?