sandy | fire #29
Open
sandy | fire #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CheezItMan
reviewed
Apr 7, 2021
CheezItMan
left a comment
CheezItMan
left a comment
There was a problem hiding this comment.
Overall nice work Sandy, the methods all work, except for delete, min and max, but otherwise you met the learning goals. Not bad. Take a look at my comments and let me know what questions you have.
Comment on lines
+20
to
+22
| # Time Complexity: O(1) | ||
| # Space Complexity:? O(1) | ||
| def add_first(value) |
Comment on lines
+29
to
+31
| # Time Complexity: O(n) | ||
| # Space Complexity: O(n) | ||
| def search(value) |
There was a problem hiding this comment.
👍 , but the space complexity is O(1)
| # returns the data value and not the node | ||
| def find_max | ||
| raise NotImplementedError | ||
| def find_max |
There was a problem hiding this comment.
This works, except when the list is empty.
Comment on lines
+59
to
+61
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def find_min |
There was a problem hiding this comment.
This works, except when the list is empty.
Comment on lines
+77
to
+79
| # Time Complexity: O(1) | ||
| # Space Complexity: O(1) | ||
| def get_first |
Comment on lines
+111
to
+113
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def get_at_index(index) |
Comment on lines
+127
to
+129
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def visit |
Comment on lines
+140
to
+142
| def delete(value) | ||
| # ?? | ||
| end |
Comment on lines
+145
to
+147
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def reverse |
Comment on lines
+161
to
+163
| # Time Complexity: O(n) | ||
| # Space Complexity: O(1) | ||
| def get_last |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.