Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

migrate to fern 0.7 - fern 0.6 with "colored" feature and custom allocator has potential soundness issues #496

Open
decathorpe opened this issue Nov 6, 2024 · 0 comments · May be fixed by #497
Open

migrate to fern 0.7 - fern 0.6 with "colored" feature and custom allocator has potential soundness issues #496

decathorpe opened this issue Nov 6, 2024 · 0 comments · May be fixed by #497

Comments

@decathorpe
Copy link

fern <0.7 with the "colored" feature enabled and a custom global allocator (as used in this project) is insecure:
https://github.com/daboross/fern/blob/fern-0.6.2/README.md

It looks like aw-server only uses a custom allocator on Linux, and this issue only affects Windows:
https://rustsec.org/advisories/RUSTSEC-2021-0145.html

But it might still be a good idea to update the fern dependency to 0.7 to avoid depending on the unmaintained atty crate.
wojnilowicz added a commit to wojnilowicz/aw-server-rust that referenced this issue Nov 7, 2024
@wojnilowicz
build(deps): bump fern from 0.6.0 to 0.7.0
2b66f2d 
Fixes ActivityWatch#496
@wojnilowicz wojnilowicz linked a pull request Nov 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(deps): bump fern from 0.6.0 to 0.7.0 wojnilowicz/aw-server-rust
1 participant
@decathorpe