-
-
Notifications
You must be signed in to change notification settings - Fork 110
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: progress on audible-as-active #262
Conversation
Codecov Report
@@ Coverage Diff @@
## master #262 +/- ##
==========================================
- Coverage 13.89% 13.84% -0.06%
==========================================
Files 22 22
Lines 1036 1040 +4
Branches 101 105 +4
==========================================
Hits 144 144
- Misses 847 851 +4
Partials 45 45
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Surprised that it was this clean to implement, can't really see any flaws. Well done!
…egory filter dropdown
Did a bit more testing, seems to work fine. Merging when CI passes. |
@ErikBjare Not working with aw-server-rust, there was one query method missing (forgotten which one, noticed a few days ago). I think it should be pretty easy to fix though. |
I assume it's period_union? |
Seems like this feature doesn't work on Brave due to ActivityWatch/activitywatch#461. Can anyone else confirm? The tab activity is being marked as audible, but I think since the browser watcher isn't working it fails to qualify for the AFK exception. I think the relevant code might be around this area: https://github.com/ActivityWatch/aw-webui/pull/262/files#diff-97651250ee5b39a1d46e9d92b574a8d7ee98ebb31335fb8bc3ee072641097f9aR73-R78 Looks like #375 might be a workaround but doesn't appear to be available in latest (0.12.1). |
I just banged this out without testing it at all, not sure if it'll work.
Edit: Huh, it wasn't too stupid after all. Seems to work...
Also re-adds the 'filter AFK' option.
Replaces #85
Partially fixes ActivityWatch/activitywatch#261
Things to fix