Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new version for rails 6.1? #19

Open
PikachuEXE opened this issue Oct 5, 2022 · 5 comments
Open

Release new version for rails 6.1? #19

PikachuEXE opened this issue Oct 5, 2022 · 5 comments

Comments

@PikachuEXE
Copy link
Collaborator

This fix commit is not released:
a2ab0b0

@ReneB
Copy link
Collaborator

ReneB commented Oct 14, 2022

Hi @PikachuEXE - I think it has been, in the 6.1.0 release last January. If I download that version directly and look at the code, I see that the code in lib/active_record/like.rb matches the code in that commit. Could you verify?

@PikachuEXE
Copy link
Collaborator Author

6.1.0 locks activerecord at ~> 6.0

image

@ReneB
Copy link
Collaborator

ReneB commented Oct 17, 2022

Hi @PikachuEXE, that makes sense! I've just released activerecord-like 7.0.0. Could you check if that solves your issue?

As an aside, I have not done any real Ruby development in years, and this gem would be better of being maintained by someone who actually uses it, tests it, and has the time to build new releases for it. Would it work for you if I transferred this repo and the rubygems.org maintenance-related rights to you?

(I also notice some tests fail on the latest build, but that seems to be because some internals for ActiveRecord/Arel have changed - which makes sense, but is one of the reasons this thing is hard to maintain for me because I haven't been able to work with those things for years, let alone their internals.)

@PikachuEXE
Copy link
Collaborator Author

On Github it's easier to make a team/organization and just add members to it (or transfer owner if you want :)
On rubygems I am not sure about the permission model, just add releaser?

@PikachuEXE
Copy link
Collaborator Author

activerecord-like 7.0.0 tested locally

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants