-
Notifications
You must be signed in to change notification settings - Fork 7
PMK-1761: Publish MCP to NPM Prep #19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… lock, publish setup, additional comments
J0SUEFDZ
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me! 💯
ewood-ac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 suggestion but nothing to keep it from going out.
README.md
Outdated
| | POSTMARK_SERVER_TOKEN | Your Postmark server API token | Yes | | ||
| | DEFAULT_SENDER_EMAIL | Default sender email address | Yes | | ||
| | DEFAULT_MESSAGE_STREAM | Postmark message stream (e.g., 'outbound') | Yes | | ||
| **Important:** This is intended for local development purposes only. Secrets should never be stored in version control. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this is the place, but it might be a nice idea to mention adding the .env to the git ignore. This would be a nice call out/reminder on how to keep the secrets from being added to version control.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed! Good callout.
| "description": "Universal Postmark MCP server using official SDK", | ||
| "description": "Official Postmark MCP server for sending emails via Claude and AI assistants", | ||
| "keywords": ["postmark", "email", "mcp", "ai"], | ||
| "author": "Jabal Torres", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rock on
ccflack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat!
ccflack
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Project cleanup and preparation to publish to NPM.
package.jsonpublish updates