Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature] library should also export src/common/base/types.dart #580

Open
grundid opened this issue Apr 17, 2024 · 1 comment
Open

[Feature] library should also export src/common/base/types.dart #580

grundid opened this issue Apr 17, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@grundid
Copy link

grundid commented Apr 17, 2024

Use case

It would be nice if you could also add the above file to exports.
Otherwise one cannot create a wrapper and use fields like "SuggestionsItemBuilder" around this widget without having to access an internal file of the library.

Proposal

add the following to flutter_typeahead.dart

export 'package:flutter_typeahead/src/common/base/types.dart';
@grundid grundid added the enhancement New feature or request label Apr 17, 2024
@clragon clragon self-assigned this May 26, 2024
@clragon
Copy link
Collaborator

clragon commented May 26, 2024

Thank you for your issue. The reason these have been omitted is that we dont wish to pollute the namespace of the person importing it.
However, I do generally agree that these types are important for wrappers, so I think we should indeed export them regardless.
Before we do that, we should ensure that they have distinct names that are unlikely to clash with anything else.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants