Skip to content

Commit 492284f

Browse files
douglas-raillard-armmarcbonnici
authored andcommitted
module/cpufreq: Fix typo
Fix per-cpu/global cpufreq governor tunable setting by replacing a "pass" into a "continue". Also name some futures to improve error reporting.
1 parent fefdf29 commit 492284f

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

devlib/module/cpufreq.py

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -163,6 +163,7 @@ async def set_per_cpu_tunables(cpu):
163163
set_per_cpu_tunables(cpu)
164164
for cpu in domains
165165
)
166+
per_cpu_tunables.__qualname__ = 'CpufreqModule.use_governor.<locals>.per_cpu_tunables'
166167

167168
# Non-per-cpu tunables have to be set one after the other, for each
168169
# governor that we had to deal with.
@@ -175,6 +176,7 @@ async def set_per_cpu_tunables(cpu):
175176
self.set_governor_tunables.asyn(cpu, gov, per_cpu=False, **tunables)
176177
for gov, (cpu, tunables) in global_tunables.items()
177178
)
179+
global_tunables.__qualname__ = 'CpufreqModule.use_governor.<locals>.global_tunables'
178180

179181
# Set the governor first
180182
await self.target.async_manager.concurrently(
@@ -280,7 +282,7 @@ async def set_governor_tunables(self, cpu, governor=None, per_cpu=None, **kwargs
280282
for tunable, value in kwargs.items():
281283
if tunable in valid_tunables:
282284
if per_cpu is not None and gov_per_cpu != per_cpu:
283-
pass
285+
continue
284286

285287
if gov_per_cpu:
286288
path = '/sys/devices/system/cpu/{}/cpufreq/{}/{}'.format(cpu, governor, tunable)

0 commit comments

Comments
 (0)