Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image editing toolbar (Rotate, Blur) #33

Open
wants to merge 20 commits into
base: main
Choose a base branch
from
Open

Image editing toolbar (Rotate, Blur) #33

wants to merge 20 commits into from

Conversation

prokawsar
Copy link
Collaborator

@prokawsar prokawsar commented Apr 28, 2024 •
edited
Loading

Scope of #12

-> Added navigate image with arrow

These operations are implemented as of now.
-> Rotate
-> Blur

Demo video: https://app.screencast.com/5xJevoPMxV3L6

Remaining
-> Brush
-> Crop
-> Text

@prokawsar prokawsar linked an issue Apr 28, 2024 that may be closed by this pull request
Gallery view: image editing toolbar #12
Open
@prokawsar prokawsar self-assigned this May 17, 2024
@prokawsar prokawsar marked this pull request as ready for review May 17, 2024 04:10
@prokawsar prokawsar changed the title Image editing toolbar WIP Image editing toolbar (Rotate, Blur) May 20, 2024
@kirillt
Copy link
Member

kirillt commented May 23, 2024

@ryabovpavel could you check how this PR works using the installers from CI? the latest build must be here https://github.com/ARK-Builders/ARK-Gallery/tree/image-editing-toolbar

@prokawsar prokawsar marked this pull request as draft May 25, 2024 11:14
@prokawsar
Copy link
Collaborator Author

Need to work again after merging #32

@ryabovpavel
Copy link
Collaborator

@ryabovpavel could you check how this PR works using the installers from CI? the latest build must be here https://github.com/ARK-Builders/ARK-Gallery/tree/image-editing-toolbar

@kirillt the latest builds on this tree are working fine 👌

@kirillt
Copy link
Member

kirillt commented Jun 13, 2024

@prokawsar is here any work needed to do before merging?

@prokawsar
Copy link
Collaborator Author

@prokawsar is here any work needed to do before merging?

Image changes apply action is not implemented yet.
I guess, it should be saved for local file, right? If so, it's might be rust level work.

@prokawsar prokawsar marked this pull request as ready for review June 16, 2024 02:56
@prokawsar prokawsar requested a review from alvinosh June 16, 2024 02:56
@kirillt
Copy link
Member

kirillt commented Jun 16, 2024

@prokawsar

Image changes apply action is not implemented yet. I guess, it should be saved for local file, right? If so, it's might be rust level work.

Yep, we need to save new image on disk. But we can register a follow-up issue for this.

@prokawsar
Copy link
Collaborator Author

@kirillt

Yep, we need to save new image on disk. But we can register a follow-up issue for this.

If we make a follow-up issue for saving image, I think, we can merge this PR now.

@kirillt kirillt self-requested a review July 3, 2024 06:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kirillt kirillt kirillt approved these changes

@alvinosh alvinosh Awaiting requested review from alvinosh

Assignees

@prokawsar prokawsar

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Gallery view: image editing toolbar
3 participants
@prokawsar @kirillt @ryabovpavel