Skip to content

Commit d014d6d

Browse files
committed
fix(acbs/utils.py): use ~dirty suffix for uncommited tree
Previously, when we used -dirty, the second dash (-) was considered the actual delimiter for REL. If the previous package version already contained a REL (now the first dash), then the segment between the beginning and the second dash would be considered the VER - making the package version higher than any comparable candidate without the -dirty suffix. Revise -dirty as ~dirty to close this loophole.
1 parent 859f207 commit d014d6d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

acbs/utils.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ def generate_version_stamp(task: ACBSPackageInfo) -> str:
217217
)
218218
stamp += 'Z'
219219
if dirty:
220-
stamp += '-dirty'
220+
stamp += '~dirty'
221221
logging.info(f'Using version stamp: {stamp}')
222222
return stamp
223223
except subprocess.CalledProcessError as ex:

0 commit comments

Comments
 (0)