Skip to content
This repository was archived by the owner on Jun 7, 2023. It is now read-only.

CI/CD #4

Open
durandom opened this issue May 15, 2020 · 10 comments
Open

CI/CD #4

durandom opened this issue May 15, 2020 · 10 comments
Labels
good first issue Good for newcomers kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@durandom
Copy link
Member

not sure if this is the right repo.
How can we test the notebooks? Can we execute all cells before a build?

@harshad16
Copy link
Member

not sure if this is the right repo.

@durandom for time being this repository feels the best place for discussion.

How can we test the notebooks? Can we execute all cells before a build?

Like a pre-test, if the notebook is in running condition?

@goern
Copy link
Member

goern commented May 16, 2020

Like a pre-test, if the notebook is in running condition?

Ja, its a functional test before merge, before tag-release

@goern
Copy link
Member

goern commented May 16, 2020

@crobby @vpavlin

@4n4nd
Copy link

4n4nd commented May 16, 2020

@harshad16 maybe we can just run ipython my_notebook.ipynb inside the s2i tests and check if the command fails

@tumido
Copy link
Member

tumido commented Jun 2, 2020

Hi, we have something in plan and already in place in the openshift sme automation. Let's coordinate that with you. 🙂

  • We use nbconvert to execute the notebooks in automation, can be reused as a CI.
  • We plan on using nbtoolbelt to verify the formal side of notebooks as a CI pipeline.

Sources and config on that are internal for now, can be viewed here: https://gitlab.cee.redhat.com/mcliffor/openshift-sme-topic-modeling

@harshad16
Copy link
Member

Hi, we have something in plan and already in place in the openshift sme automation. Let's coordinate that with you.

  • We use nbconvert to execute the notebooks in automation, can be reused as a CI.
  • We plan on using nbtoolbelt to verify the formal side of notebooks as a CI pipeline.

Sources and config on that are internal for now, can be viewed here: https://gitlab.cee.redhat.com/mcliffor/openshift-sme-topic-modeling

Surely, let coordinate, we will go over the following libraries and sync up with you.

@goern goern mentioned this issue Jun 3, 2020
@sesheta
Copy link
Contributor

sesheta commented Jul 2, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 2, 2021
@harshad16
Copy link
Member

/remove-lifecycle stale

@sesheta sesheta removed the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 14, 2021
@harshad16 harshad16 added kind/feature Categorizes issue or PR as related to a new feature. priority/backlog Higher priority than priority/awaiting-more-evidence. good first issue Good for newcomers labels Jul 14, 2021
@sesheta
Copy link
Contributor

sesheta commented Oct 16, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Oct 16, 2021
@sesheta
Copy link
Contributor

sesheta commented Nov 15, 2021

Stale issues rot after 30d of inactivity.
Mark the issue as fresh with /remove-lifecycle rotten.
Rotten issues close after an additional 30d of inactivity.

If this issue is safe to close now please do so with /close.

/lifecycle rotten

@sesheta sesheta added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Nov 15, 2021
@harshad16 harshad16 added lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. labels Dec 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
good first issue Good for newcomers kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

6 participants