Skip to content
This repository was archived by the owner on Jun 7, 2023. It is now read-only.

make notebook folder configurable #13

Open
durandom opened this issue Jun 10, 2020 · 4 comments
Open

make notebook folder configurable #13

durandom opened this issue Jun 10, 2020 · 4 comments
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.

Comments

@durandom
Copy link
Member

If you start many content notebook images, you'll end up with a bunch of notebooks-<date> folders.
Can we start with naming the folder after the repo that the image was built from?
So that https://gitlab.cee.redhat.com/AICoE/ocp4/ results in ocp4-<date> ?
Actually thinking about it, it might be more straight forward to add a simple config .notebooks.yaml into the notebooks folder that configures exactly this. That way we can sneak in more control over the build and deploy process.

notebooks_folder_name: "notebooks"
@4n4nd
Copy link

4n4nd commented Jun 10, 2020

@durandom this has already been implemented.
Did it not work for you?

@durandom
Copy link
Member Author

I just saw that we name the folder after the git repo. Implemeted via https://github.com/AICoE/s2i-custom-notebook/pull/5/files

That's good. I guess I was missing the documentation.

Let's keep this issue still open, maybe we want to make it configurable.

@sesheta sesheta added kind/feature Categorizes issue or PR as related to a new feature. and removed enhancement labels Feb 8, 2021
@sesheta
Copy link
Contributor

sesheta commented Jul 2, 2021

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

/lifecycle stale

@sesheta sesheta added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jul 2, 2021
@harshad16
Copy link
Member

/lifecycle frozen
/priority backlog

@sesheta sesheta added priority/backlog Higher priority than priority/awaiting-more-evidence. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/feature Categorizes issue or PR as related to a new feature. lifecycle/frozen Indicates that an issue or PR should not be auto-closed due to staleness. priority/backlog Higher priority than priority/awaiting-more-evidence.
Projects
None yet
Development

No branches or pull requests

4 participants