-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
What is the best practice for when to send completed or passed statements? #715
Comments
Without knowing the vendor tool(s) used to generate the AUs I could posit a couple of guesses.
As mentioned in other places, it isn't necessarily the work of the spec to instruct people on better development practices for their implementation. (Lest we have a lot of work to do ;-).) |
Having said that, I want to be clear, that I don't think you're wrong about what should be done as good practice, merely that I don't think we need to call all of it out. |
In another issue we are were discussing the returnURL. If the LMS makes use the returnURL, you likely solve this issue. The content I've seen has a button at the end that returns to the LMS. At the point, all the statements should have been sent. If not, the content would need to send them before executing the return. |
We could add this to "bad practices" |
(Reviewed per June 3, 20220 meeting) |
I have noted multiple cmi5 units from different vendors send passed and completed statements just before (or maybe with) the terminated statement.
The trigger in the AU for passed and completed statements appears to be the window close event. I believe this to be bad practice because window close events are not guaranteed happen (see #714).
I suggest best practice would be for the AU to send completed or passed statements as soon as the AU is passed or completed and not wait for a window close event.
As an aside, I am puzzled why multiple vendors would implement this same logic, is there something in the spec or the best practices that I am missing?
The text was updated successfully, but these errors were encountered: