Merge pull request #44 from 9oormthon-univ/feat/#42

#42 Fix : 빈 순환 수정

Author: mingmingmon

src/main/java/com/univ/sohwakhaeng/product/api/ProductController.java

@@ -1,6 +1,7 @@
 package com.univ.sohwakhaeng.product.api;
 
 import com.univ.sohwakhaeng.enterprise.Category;
+import com.univ.sohwakhaeng.enterprise.Enterprise;
 import com.univ.sohwakhaeng.enterprise.api.dto.EnterpriseDetailDto;
 import com.univ.sohwakhaeng.enterprise.api.dto.EnterpriseOverviewDto;
 import com.univ.sohwakhaeng.enterprise.api.dto.EnterpriseRequestDto;
@@ -9,6 +10,7 @@
 import com.univ.sohwakhaeng.global.common.dto.BaseResponse;
 import com.univ.sohwakhaeng.global.common.dto.PagedResponseDto;
 import com.univ.sohwakhaeng.global.common.exception.SuccessCode;
+import com.univ.sohwakhaeng.product.Product;
 import com.univ.sohwakhaeng.product.api.dto.ProductRequestDto;
 import com.univ.sohwakhaeng.product.service.ProductService;
 import java.util.List;
@@ -28,11 +30,18 @@
 public class ProductController {
 
     private final ProductService productService;
+    private final EnterpriseService enterpriseService;
 
     @PostMapping("/public/products")
     public BaseResponse<Void> postProducts(@RequestBody List<ProductRequestDto> dtos) throws EnterpriseNotFoundException {
+
+        for (ProductRequestDto dto : dtos) {
+            Enterprise enterprise = enterpriseService.getEnterpriseEntityById(dto.enterpriseId());
+            productService.saveProduct(Product.createProduct(dto, enterprise));
+        }
+
         return BaseResponse.success(
-                SuccessCode.GET_ENTERPRISE_DETAILS, productService.postProducts(dtos));
+                SuccessCode.GET_ENTERPRISE_DETAILS, null);
     }
 
 }

src/main/java/com/univ/sohwakhaeng/product/service/ProductService.java

@@ -21,26 +21,11 @@
 @RequiredArgsConstructor
 public class ProductService {
 
-    private EnterpriseService enterpriseService;
-    private ProductRepository productRepository;
-    private AmazonS3Client amazonS3Client;
-    public ProductService(EnterpriseService enterpriseService, ProductRepository productRepository, AmazonS3Client amazonS3Client) {
-        this.enterpriseService = enterpriseService;
-        this.productRepository = productRepository;
-        this.amazonS3Client = amazonS3Client;
-    }
-
+    private final ProductRepository productRepository;
+    private final AmazonS3Client amazonS3Client;
     @Value("${cloud.aws.s3.bucket}")
     private String awsBucket;
 
-    public Void postProducts(List<ProductRequestDto> dtos) throws EnterpriseNotFoundException {
-        for (ProductRequestDto dto : dtos) {
-            Enterprise enterprise = enterpriseService.getEnterpriseEntityById(dto.enterpriseId());
-            saveProduct(Product.createProduct(dto, enterprise));
-        }
-        return null;
-    }
-
     public void saveProduct(Product product) {
         productRepository.save(product);
     }