Remove msg and format from start-process init token; error handling in etw-input-node; JSON.stringify in node.error removed

moellenbeck · moellenbeck · commit 213c785d7fd6 · 2025-01-15T18:12:24.000+01:00
diff --git a/endevent-finished-listener.js b/endevent-finished-listener.js
@@ -21,7 +21,7 @@ module.exports = function (RED) {
                     });
                 });
             } catch (error) {
-                node.error(JSON.stringify(error));
+                node.error(error);
             }
 
             node.on('close', async () => {
diff --git a/externaltask-input.js b/externaltask-input.js
@@ -179,7 +179,9 @@ module.exports = function (RED) {
         };
 
         if (node.engine) {
-            register();
+            register().catch((error) => {
+                node.error(error);
+            });
         }
     }
 
diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
     "name": "@5minds/node-red-contrib-processcube",
-    "version": "1.6.4",
+    "version": "1.6.5",
     "license": "MIT",
     "description": "Node-RED nodes for ProcessCube",
     "scripts": {
diff --git a/process-event-listener.js b/process-event-listener.js
@@ -51,7 +51,7 @@ module.exports = function (RED) {
                                     });
                                 }
                             } catch (error) {
-                                node.error(JSON.stringify(error));
+                                node.error(error);
                             }
                             
                         });
@@ -90,7 +90,7 @@ module.exports = function (RED) {
                                     });
                                 }
                             } catch (error) {
-                                node.error(JSON.stringify(error));
+                                node.error(error);
                             }
                         });
                     case 'resumed':
@@ -123,7 +123,7 @@ module.exports = function (RED) {
                                     });
                                 }
                             } catch (error) {
-                                node.error(JSON.stringify(error));
+                                node.error(error);
                             }
                         });
                     case 'finished':
@@ -157,7 +157,7 @@ module.exports = function (RED) {
                                     });
                                 }
                             } catch (error) {
-                                node.error(JSON.stringify(error));
+                                node.error(error);
                             }
                         });
                     case 'terminated':
@@ -189,7 +189,7 @@ module.exports = function (RED) {
                                     });
                                 }
                             } catch (error) {
-                                node.error(JSON.stringify(error));
+                                node.error(error);
                             }
                         });
                     case 'error':
@@ -222,7 +222,7 @@ module.exports = function (RED) {
                                     });
                                 }
                             } catch (error) {
-                                node.error(JSON.stringify(error));
+                                node.error(error);
                             }
                         });
                     case 'owner-changed':
@@ -254,7 +254,7 @@ module.exports = function (RED) {
                                     });
                                 }
                             } catch (error) {
-                                node.error(JSON.stringify(error));
+                                node.error(error);
                             }
                         });
                     case 'instances-deleted':
@@ -286,7 +286,7 @@ module.exports = function (RED) {
                                     });
                                 }
                             } catch (error) {
-                                node.error(JSON.stringify(error));
+                                node.error(error);
                             }
                         });
                     case 'is-executable-changed':
diff --git a/process-start.js b/process-start.js
@@ -4,7 +4,11 @@ module.exports = function (RED) {
         var node = this;
 
         node.on('input', function (msg) {
-            const initialToken = RED.util.encodeObject(msg.payload);
+            let initialToken = RED.util.encodeObject(msg.payload);
+
+            // remote msg and format from result
+            delete initialToken.msg;
+            delete initialToken.format;
 
             const startParameters = {
                 processModelId: msg.processModelId || config.processmodel,
@@ -43,7 +47,7 @@ module.exports = function (RED) {
                     });
                 })
                 .catch((error) => {
-                    node.error(JSON.stringify(error));
+                    node.error(error);
                 });
         });
     }
diff --git a/process-terminate.js b/process-terminate.js
@@ -18,7 +18,7 @@ module.exports = function (RED) {
                     node.send(msg);
                 })
                 .catch((error) => {
-                    node.error(JSON.stringify(error));
+                    node.error(error);
                 });
         });
     }
diff --git a/processcube-engine-config.js b/processcube-engine-config.js
@@ -24,7 +24,7 @@ module.exports = function (RED) {
                 node.engineClient = new engine_client.EngineClient(node.url);
             }
         } catch (error) {
-            node.error(JSON.stringify(error));
+            node.error(error);
         }
 
         node.on('close', async () => {
diff --git a/processdefinition-query.js b/processdefinition-query.js
@@ -39,7 +39,7 @@ module.exports = function (RED) {
                     node.send(msg);
                 })
                 .catch((error) => {
-                    node.error(JSON.stringify(error));
+                    node.error(error);
                 });
         });
     }
diff --git a/signal-event-trigger.js b/signal-event-trigger.js
@@ -29,7 +29,7 @@ module.exports = function (RED) {
                     });
                 })
                 .catch((error) => {
-                    node.error(JSON.stringify(error));
+                    node.error(error);
                 });
         });
     }
diff --git a/usertask-event-listener.js b/usertask-event-listener.js
@@ -42,7 +42,7 @@ module.exports = function (RED) {
                             });
                         }
                     } catch (error) {
-                        node.error(JSON.stringify(error));
+                        node.error(error);
                     }
                 };
             }
diff --git a/usertask-input.js b/usertask-input.js
@@ -32,7 +32,7 @@ module.exports = function (RED) {
                     } else node.log(`No user tasks found for query: ${JSON.stringify(query)}`);
                 })
                 .catch((error) => {
-                    node.error(JSON.stringify(error));
+                    node.error(error);
                 });
         });
     }
diff --git a/usertask-output.js b/usertask-output.js
@@ -29,7 +29,7 @@ module.exports = function (RED) {
                         node.send(msg);
                     })
                     .catch((error) => {
-                        node.error(JSON.stringify(error));
+                        node.error(error);
                     });
             } else {
                 node.error(`No UserTask found in message: ${JSON.stringify(msg.payload)}`);
diff --git a/wait-for-usertask.js b/wait-for-usertask.js
@@ -39,7 +39,7 @@ module.exports = function (RED) {
                             // nothing todo - wait for next notification
                         }
                     } catch (error) {
-                        node.error(JSON.stringify(error));
+                        node.error(error);
                     }
                 });
 
@@ -67,7 +67,7 @@ module.exports = function (RED) {
                             // let the *currentIdentity* be active
                         }
                     } catch (error) {
-                        node.error(JSON.stringify(error));
+                        node.error(error);
                     }
                 }
             };

Original file line number	Diff line number	Diff line change
`@@ -21,7 +21,7 @@ module.exports = function (RED) {`
`21`	`21`	`});`
`22`	`22`	`});`
`23`	`23`	`} catch (error) {`
`24`		`- node.error(JSON.stringify(error));`
	`24`	`+ node.error(error);`
`25`	`25`	`}`
`26`	`26`
`27`	`27`	`node.on('close', async () => {`
Original file line number	Diff line number	Diff line change
`@@ -179,7 +179,9 @@ module.exports = function (RED) {`
`179`	`179`	`};`
`180`	`180`
`181`	`181`	`if (node.engine) {`
`182`		`- register();`
	`182`	`+ register().catch((error) => {`
	`183`	`+ node.error(error);`
	`184`	`+ });`
`183`	`185`	`}`
`184`	`186`	`}`
`185`	`187`
Original file line number	Diff line number	Diff line change
`@@ -1,6 +1,6 @@`
`1`	`1`	`{`
`2`	`2`	`"name": "@5minds/node-red-contrib-processcube",`
`3`		`- "version": "1.6.4",`
	`3`	`+ "version": "1.6.5",`
`4`	`4`	`"license": "MIT",`
`5`	`5`	`"description": "Node-RED nodes for ProcessCube",`
`6`	`6`	`"scripts": {`
Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ module.exports = function (RED) {`
`51`	`51`	`});`
`52`	`52`	`}`
`53`	`53`	`} catch (error) {`
`54`		`- node.error(JSON.stringify(error));`
	`54`	`+ node.error(error);`
`55`	`55`	`}`
`56`	`56`
`57`	`57`	`});`
`@@ -90,7 +90,7 @@ module.exports = function (RED) {`
`90`	`90`	`});`
`91`	`91`	`}`
`92`	`92`	`} catch (error) {`
`93`		`- node.error(JSON.stringify(error));`
	`93`	`+ node.error(error);`
`94`	`94`	`}`
`95`	`95`	`});`
`96`	`96`	`case 'resumed':`
`@@ -123,7 +123,7 @@ module.exports = function (RED) {`
`123`	`123`	`});`
`124`	`124`	`}`
`125`	`125`	`} catch (error) {`
`126`		`- node.error(JSON.stringify(error));`
	`126`	`+ node.error(error);`
`127`	`127`	`}`
`128`	`128`	`});`
`129`	`129`	`case 'finished':`
`@@ -157,7 +157,7 @@ module.exports = function (RED) {`
`157`	`157`	`});`
`158`	`158`	`}`
`159`	`159`	`} catch (error) {`
`160`		`- node.error(JSON.stringify(error));`
	`160`	`+ node.error(error);`
`161`	`161`	`}`
`162`	`162`	`});`
`163`	`163`	`case 'terminated':`
`@@ -189,7 +189,7 @@ module.exports = function (RED) {`
`189`	`189`	`});`
`190`	`190`	`}`
`191`	`191`	`} catch (error) {`
`192`		`- node.error(JSON.stringify(error));`
	`192`	`+ node.error(error);`
`193`	`193`	`}`
`194`	`194`	`});`
`195`	`195`	`case 'error':`
`@@ -222,7 +222,7 @@ module.exports = function (RED) {`
`222`	`222`	`});`
`223`	`223`	`}`
`224`	`224`	`} catch (error) {`
`225`		`- node.error(JSON.stringify(error));`
	`225`	`+ node.error(error);`
`226`	`226`	`}`
`227`	`227`	`});`
`228`	`228`	`case 'owner-changed':`
`@@ -254,7 +254,7 @@ module.exports = function (RED) {`
`254`	`254`	`});`
`255`	`255`	`}`
`256`	`256`	`} catch (error) {`
`257`		`- node.error(JSON.stringify(error));`
	`257`	`+ node.error(error);`
`258`	`258`	`}`
`259`	`259`	`});`
`260`	`260`	`case 'instances-deleted':`
`@@ -286,7 +286,7 @@ module.exports = function (RED) {`
`286`	`286`	`});`
`287`	`287`	`}`
`288`	`288`	`} catch (error) {`
`289`		`- node.error(JSON.stringify(error));`
	`289`	`+ node.error(error);`
`290`	`290`	`}`
`291`	`291`	`});`
`292`	`292`	`case 'is-executable-changed':`
Original file line number	Diff line number	Diff line change
`@@ -18,7 +18,7 @@ module.exports = function (RED) {`
`18`	`18`	`node.send(msg);`
`19`	`19`	`})`
`20`	`20`	`.catch((error) => {`
`21`		`- node.error(JSON.stringify(error));`
	`21`	`+ node.error(error);`
`22`	`22`	`});`
`23`	`23`	`});`
`24`	`24`	`}`
Original file line number	Diff line number	Diff line change
`@@ -24,7 +24,7 @@ module.exports = function (RED) {`
`24`	`24`	`node.engineClient = new engine_client.EngineClient(node.url);`
`25`	`25`	`}`
`26`	`26`	`} catch (error) {`
`27`		`- node.error(JSON.stringify(error));`
	`27`	`+ node.error(error);`
`28`	`28`	`}`
`29`	`29`
`30`	`30`	`node.on('close', async () => {`
Original file line number	Diff line number	Diff line change
`@@ -39,7 +39,7 @@ module.exports = function (RED) {`
`39`	`39`	`node.send(msg);`
`40`	`40`	`})`
`41`	`41`	`.catch((error) => {`
`42`		`- node.error(JSON.stringify(error));`
	`42`	`+ node.error(error);`
`43`	`43`	`});`
`44`	`44`	`});`
`45`	`45`	`}`
Original file line number	Diff line number	Diff line change
`@@ -29,7 +29,7 @@ module.exports = function (RED) {`
`29`	`29`	`});`
`30`	`30`	`})`
`31`	`31`	`.catch((error) => {`
`32`		`- node.error(JSON.stringify(error));`
	`32`	`+ node.error(error);`
`33`	`33`	`});`
`34`	`34`	`});`
`35`	`35`	`}`
Original file line number	Diff line number	Diff line change
`@@ -42,7 +42,7 @@ module.exports = function (RED) {`
`42`	`42`	`});`
`43`	`43`	`}`
`44`	`44`	`} catch (error) {`
`45`		`- node.error(JSON.stringify(error));`
	`45`	`+ node.error(error);`
`46`	`46`	`}`
`47`	`47`	`};`
`48`	`48`	`}`
Original file line number	Diff line number	Diff line change
`@@ -32,7 +32,7 @@ module.exports = function (RED) {`
`32`	`32`	} else node.log(`No user tasks found for query: ${JSON.stringify(query)}`);
`33`	`33`	`})`
`34`	`34`	`.catch((error) => {`
`35`		`- node.error(JSON.stringify(error));`
	`35`	`+ node.error(error);`
`36`	`36`	`});`
`37`	`37`	`});`
`38`	`38`	`}`