Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Trilinos] Update to newer version #288

Open
2 tasks
maxfirmbach opened this issue Jan 27, 2025 · 5 comments
Open
2 tasks

[Trilinos] Update to newer version #288

maxfirmbach opened this issue Jan 27, 2025 · 5 comments
Labels
priority: medium Issues with medium priority type: enhancement A new feature or enhancement to be implemented

Comments

@maxfirmbach
Copy link
Contributor

Description

I would like to update the Trilinos version, which is used by 4C. In the past few months there has been quite a lot of bug fixes (see #176).

Possible Solution and Definition of Done

  • Update on IMCS
  • Update on LNM

Interested Parties

@mayrmt @c-p-schmidt @davidrudlstorfer

@maxfirmbach maxfirmbach added the type: enhancement A new feature or enhancement to be implemented label Jan 27, 2025
@mayrmt
Copy link
Member

mayrmt commented Jan 27, 2025

Good idea!

@davidrudlstorfer
Copy link
Contributor

Sounds like a good plan @maxfirmbach

One thing I would like to mention is that it probably would make sense to somehow "limit" or "plan" the Trilinos Updates. For me the Trilinos Updates involve some effort to update on the clusters. This update would mark the third Trilinos Update in the last 6 months.

Would it make sense to somehow tie the Trilinos Updates to 4C release versions? For example create a new 4C release every 6 months and update Trilinos with these releases? Either before or after?

I understand that prominent bug fixes are important but I do not want that we end up updating Trilinos 6 times a year :D

@maxfirmbach
Copy link
Contributor Author

Sounds like a good plan @maxfirmbach

One thing I would like to mention is that it probably would make sense to somehow "limit" or "plan" the Trilinos Updates. For me the Trilinos Updates involve some effort to update on the clusters. This update would mark the third Trilinos Update in the last 6 months.

Would it make sense to somehow tie the Trilinos Updates to 4C release versions? For example create a new 4C release every 6 months and update Trilinos with these releases? Either before or after?

I understand that prominent bug fixes are important but I do not want that we end up updating Trilinos 6 times a year :D

As discussed offline, I'm okay with that proposal 👍 .

@mayrmt
Copy link
Member

mayrmt commented Jan 27, 2025

@davidrudlstorfer, yes, an update of Trilinos requires time and effort -- so do all other infrastructure steps in 4C such as upgrading compilers or any other part of our development environment or changes in in put parameters and so on...

I do not want to tie Trilinos updates to any schedule. For people who do their research at the intersection of 4C and Trilinos, such a strategy would impose restrictions on their working environment and in fact force them to keep their finalized work in their own branches (at least in their own Trilinos installation). Since research happens in Trilinos as well, we need to be able to update Trilinos when the need arises.

We could (and I think we should) discuss ideas of making Trilinos updates more independent of the installations at different institutes. I have some thoughts on that. Feel free to reach out, if you want to know more.

@sebproell
Copy link
Member

We could (and I think we should) discuss ideas of making Trilinos updates more independent of the installations at different institutes. I have some thoughts on that. Feel free to reach out, if you want to know more.

@mayrmt This is an important point: we need to find a strategy that is flexible enough to allow fast research progress for those interested in specifics of Trilinos and, at the same time, gives pure users of Trilinos some leeway when to update their dependency. I believe that it should be possible to support a range of Trilinos versions. I am quite interested in this topic since the same will, of course, apply to deal.II once we start experimenting more with the integration of its features, so please include me in any more detailed offline discussion on this topic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Issues with medium priority type: enhancement A new feature or enhancement to be implemented
Projects
None yet
Development

No branches or pull requests

5 participants