Skip to content

Commit d5ac26b

Browse files
jehrrclaude
andauthored
CI: engine-smoke checks that the engine imports, instead of a grep that could not fail (#8)
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
1 parent e5219ca commit d5ac26b

1 file changed

Lines changed: 9 additions & 1 deletion

File tree

‎.github/workflows/tests.yml‎

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -214,7 +214,15 @@ jobs:
214214
run: |
215215
set -o pipefail
216216
.venv/bin/python smoke_test.py | tee smoke.log
217-
if grep -q "${{ matrix.engine }}_scraper could not be imported" smoke.log; then
217+
# The engine this job installed must IMPORT. This step used to grep
218+
# the suite's log for "<engine>_scraper could not be imported", a
219+
# phrase this suite never prints, so it could not fail: measured
220+
# 2026-09-24 by running each repo's suite with no engine installed,
221+
# the phrase appeared in 2 of 31 logs. Importing the module is what
222+
# the step meant, it does not depend on the suite's wording, and it
223+
# fails here by name because every engine imports its driver at
224+
# module level (smoke_test.py asserts that).
225+
if ! .venv/bin/python -c "import ${{ matrix.engine }}_scraper"; then
218226
echo "FAILED: ${{ matrix.engine }}_scraper failed to import even though"
219227
echo " ${{ matrix.engine }} is installed in this job."
220228
exit 1

0 commit comments

Comments
 (0)