Rename 'cafile' to 'ca_file' in ClientConfig for consistency

Author: mattjacksoncello

USAGE.md

@@ -41,7 +41,7 @@ When connecting to a 1Password Connect server using HTTPS, you may need to confi
 from onepasswordconnectsdk.config import ClientConfig
 
 # Verify SSL using a custom CA certificate
-config = ClientConfig(cafile="path/to/ca.pem")
+config = ClientConfig(ca_file="path/to/ca.pem")
 client = new_client("https://connect.example.com", "your-token", config=config)
 
 # Disable SSL verification (not recommended for production)
@@ -56,7 +56,7 @@ The ClientConfig class accepts all httpx client options as keyword arguments. Th
 ```python
 # Configure timeouts and redirects
 config = ClientConfig(
-    cafile="path/to/ca.pem",
+    ca_file="path/to/ca.pem",
     timeout=30.0,              # 30 second timeout
     follow_redirects=True,     # Follow HTTP redirects
     max_redirects=5           # Maximum number of redirects to follow
@@ -85,7 +85,7 @@ The same configuration options work for both synchronous and asynchronous client
 
 ```python
 config = ClientConfig(
-    cafile="path/to/ca.pem",
+    ca_file="path/to/ca.pem",
     timeout=30.0
 )
 async_client = new_client("https://connect.example.com", "your-token", is_async=True, config=config)

example/ca_file_example/list_secrets.py

@@ -25,7 +25,7 @@ def list_vault_secrets():
     try:
         # Configure client with CA certificate verification
         config = ClientConfig(
-            cafile=CA_FILE,
+            ca_file=CA_FILE,
             timeout=30.0  # 30 second timeout
         )
 
@@ -53,7 +53,7 @@ async def list_vault_secrets_async():
     try:
         # Configure client with CA certificate verification
         config = ClientConfig(
-            cafile=CA_FILE,
+            ca_file=CA_FILE,
             timeout=30.0  # 30 second timeout
         )
 

src/onepasswordconnectsdk/config.py

@@ -27,7 +27,7 @@ def __init__(self, ca_file: Optional[str] = None, **kwargs):
         """Initialize client configuration
 
         Args:
-            cafile (Optional[str]): Path to CA certificate file for SSL verification
+            ca_file (Optional[str]): Path to CA certificate file for SSL verification
             **kwargs: Additional httpx client options
         """
         self.ca_file = ca_file
@@ -50,9 +50,9 @@ def get_client_args(self, base_url: str, headers: Dict[str, str], timeout: float
             'timeout': timeout,
         }
 
-        # Set verify from cafile first
-        if self.cafile:
-            args['verify'] = self.cafile
+        # Set verify from ca_file first
+        if self.ca_file:
+            args['verify'] = self.ca_file
 
         # Allow httpx_options (including verify) to override
         args.update(self.httpx_options)

src/tests/test_client_config.py

@@ -2,8 +2,8 @@
 from onepasswordconnectsdk.config import ClientConfig
 import httpx
 
-def test_client_config_with_cafile():
-    config = ClientConfig(cafile="path/to/ca.pem")
+def test_client_config_with_ca_file():
+    config = ClientConfig(ca_file="path/to/ca.pem")
     args = config.get_client_args("https://test.com", {"Authorization": "Bearer token"}, 30.0)
 
     assert args["verify"] == "path/to/ca.pem"
@@ -13,7 +13,7 @@ def test_client_config_with_cafile():
 
 def test_client_config_with_kwargs():
     config = ClientConfig(
-        cafile="path/to/ca.pem",
+        ca_file="path/to/ca.pem",
         follow_redirects=True,
         timeout=60.0
     )
@@ -25,16 +25,16 @@ def test_client_config_with_kwargs():
     assert args["timeout"] == 60.0
 
 def test_client_config_verify_override():
-    # When verify is explicitly set in kwargs, it should override cafile
+    # When verify is explicitly set in kwargs, it should override ca_file
     config = ClientConfig(
-        cafile="path/to/ca.pem",
+        ca_file="path/to/ca.pem",
         verify=False
     )
     args = config.get_client_args("https://test.com", {"Authorization": "Bearer token"}, 30.0)
 
     assert args["verify"] == False
 
-def test_client_config_no_cafile():
+def test_client_config_no_ca_file():
     config = ClientConfig()
     args = config.get_client_args("https://test.com", {"Authorization": "Bearer token"}, 30.0)