workflows: add SEND balance + hodler activities (not wired) #2006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 4, 2025
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Oct 4, 2025
youngkidwarrior
force-pushed
the
types_widen_write_types_for_balance_weight_precision
branch
from
0fd629d to
87d2240
Compare
youngkidwarrior
force-pushed
the
workflows_add_send_balance_hodler_activities_not_wired_
branch
from
1fdcfd4 to
2237913
Compare
youngkidwarrior
force-pushed
the
types_widen_write_types_for_balance_weight_precision
branch
from
87d2240 to
fa92a18
Compare
youngkidwarrior
force-pushed
the
workflows_add_send_balance_hodler_activities_not_wired_
branch
2 times, most recently
from
a7f88d0 to
a2ccd91
Compare
youngkidwarrior
force-pushed
the
types_widen_write_types_for_balance_weight_precision
branch
from
fa92a18 to
6bd27f4
Compare
Why: Recent gating added complexity and caused overpopulation side effects. Revert to the simpler behavior while we decide on DB-trigger-only vs app-level DV upsert. Optimizing for speed likely favors DB triggers. Next: - Option A (recommended for speed/consistency): remove this activity and rely solely on the DB trigger (already implemented) to drive DV. - Option B: keep this always-upsert activity and remove the DB trigger. Test plan: - yarn lint; SQL tests for hodler path continue to pass.
youngkidwarrior
force-pushed
the
workflows_add_send_balance_hodler_activities_not_wired_
branch
from
a2ccd91 to
f01f6be
Compare
youngkidwarrior
force-pushed
the
types_widen_write_types_for_balance_weight_precision
branch
from
6bd27f4 to
6152588
Compare
This was referenced Oct 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
upsertSendTokenHodlerVerificationActivity (string|bigint weight; retry semantics).
Test plan: