Skip to content

bug: document formatting when using Anthropic #183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
1 task done
milancermak opened this issue Jan 6, 2025 · 2 comments · May be fixed by #184
Open
1 task done

bug: document formatting when using Anthropic #183

milancermak opened this issue Jan 6, 2025 · 2 comments · May be fixed by #184
Assignees
@0xMochan
Labels
good first issue Good for newcomers non-breaking
Milestone
2025-03-17

Comments

@milancermak
Copy link

  • I have looked for existing issues (including closed) about this

Bug Report

Anthropic expects documents to be structured in a particular XML format. This is currently not the case - the documents are wrapped in <attachments> tags.

Expected behavior

When using an Anthropic model, I expect the request from Rig to be formatted correctly according to what the Anthropic API expects and recommends.

Additional context

The issue might be resolved once #149 is addressed.
@milancermak milancermak linked a pull request Jan 6, 2025 that will close this issue
Open
@0xMochan
Copy link
Contributor

0xMochan commented Jan 6, 2025

Thanks for this issue, 100% this seems like the correct approach. The XML format chosen in the codebase currently was chosen a bit arbitrarily. It's likely that this isn't an enforced format but it's definitely a change we should make standardized.

I think this is a great first issue and either could be adapted globally OR just specifically for anthropic.

@0xMochan 0xMochan added the good first issue Good for newcomers label Jan 6, 2025
@cvauclair cvauclair added this to the 2025-03-17 milestone Mar 3, 2025
@dobleuber
Copy link

Hey! I'd like to work on this issue! @0xMochan are you working on this already?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@0xMochan 0xMochan

Labels
good first issue Good for newcomers non-breaking
Projects
None yet
Milestone
2025-03-17
Development

Successfully merging a pull request may close this issue.

fix: anthropic documents in prompt milancermak/rig
5 participants
@milancermak @cvauclair @dobleuber @joshua-mo-143 @0xMochan