refactor: [4/4] unify get_account_details and get_account_proof[s] into get_account
#1385
Conversation
drahnr
changed the title
get_account_details and get_account_proof[s]get_account_details and get_account_proof[s]
|
@igamigo could you weigh in on
|
At least a very simple version of replacing |
drahnr
force-pushed
the
bernhard-unify-get-details-and-get-proofs
branch
from
7e654d4 to
1755724
Compare
drahnr
force-pushed
the
bernhard-unify-get-details-and-get-proofs
branch
from
69e1952 to
977e30f
Compare
igamigo
left a comment
igamigo
left a comment
There was a problem hiding this comment.
LGTM! Left a few comments, mostly nits. There is only one comment related to the functionality of the network monitor that I'm wondering about.
bobbinth
left a comment
bobbinth
left a comment
There was a problem hiding this comment.
Looks good! Thank you! I left just a coupe of small comments inline.
There was a problem hiding this comment.
nit: not for this PR, but I'd try to break up this file into a couple of smaller files.
…to bernhard-partial-storage-map-queries
…fy-get-details-and-get-proofs
…tails-and-get-proofs
Unify API calls
The new API is flexible enough to address all needs and avoid loading a lot of data from the DB.
Main changes in:
crates/proto/src/domain/account.rs:AccountProofRequest→AccountRequest,AccountProofResponse→AccountResponseGetAccountDetails*Caveat
Will require client changes!
Part 2
This is part 1 of two pieces. The second piece is in and does the actual DB changes, as well as populate the
SmtForest. This is NOT part of this PR.Open Questions
Do we want compatibility on the RPC level to give the client some more migration time, or is the change bounded enough?
Part of #1349
Part 1 of 2 of the remaining pieces in #1185