Skip to content

Commit d724c14

Browse files
jusbar23pthmas
authored andcommitted
Change to warn instead of error for invalid ORRS (dydxprotocol#3036)
1 parent 54f3e86 commit d724c14

File tree

1 file changed

+10
-2
lines changed

1 file changed

+10
-2
lines changed

protocol/x/revshare/keeper/revshare.go

Lines changed: 10 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -332,7 +332,11 @@ func (k Keeper) getOrderRouterRevShares(
332332
orderRouterRevShares := []types.RevShare{}
333333
takerOrderRouterRevSharePpm, err := k.GetOrderRouterRevShare(ctx, fill.TakerOrderRouterAddr)
334334
if err != nil {
335-
k.Logger(ctx).Error("order router rev share invalid for taker: " + fill.TakerOrderRouterAddr)
335+
k.Logger(ctx).Warn("order router rev share invalid for taker, ignoring ",
336+
"taker_order_router_addr: ", fill.TakerOrderRouterAddr,
337+
"taker_addr: ", fill.TakerAddr,
338+
"error: ", err,
339+
)
336340
} else {
337341
if fill.TakerOrderRouterAddr != "" {
338342
// Orders can have 2 rev share ids, we need to calculate each side separately
@@ -351,7 +355,11 @@ func (k Keeper) getOrderRouterRevShares(
351355

352356
makerOrderRouterRevSharePpm, err := k.GetOrderRouterRevShare(ctx, fill.MakerOrderRouterAddr)
353357
if err != nil {
354-
k.Logger(ctx).Error("order router rev share invalid for maker: " + fill.MakerOrderRouterAddr)
358+
k.Logger(ctx).Warn("order router rev share invalid for maker, ignoring ",
359+
"maker_order_router_addr: ", fill.MakerOrderRouterAddr,
360+
"maker_addr: ", fill.MakerAddr,
361+
"error: ", err,
362+
)
355363
} else {
356364
if fill.MakerOrderRouterAddr != "" {
357365
// maker ppm * max(0, maker)

0 commit comments

Comments
 (0)